Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed failing tests in test_patch.py #618

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Fixed failing tests in test_patch.py #618

merged 5 commits into from
Jun 7, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Due to resent updates in EMMO, several of the tests in test_patch.py were failing.

We should consider to test against our test ontology instead of EMMO to avoid such failures.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #618 (976fe72) into master (4487cc7) will decrease coverage by 0.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   68.41%   67.81%   -0.60%     
==========================================
  Files          16       16              
  Lines        3172     3172              
==========================================
- Hits         2170     2151      -19     
- Misses       1002     1021      +19

see 2 files with indirect coverage changes

francescalb
francescalb requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one comment

francescalb
francescalb reviewed Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, but please add an issue about the tests that are going to be added back.

@francescalb francescalb self-requested a review June 7, 2023 20:48
@jesper-friis jesper-friis merged commit 4c018e0 into master Jun 7, 2023
@jesper-friis jesper-friis deleted the fix-get-parent-test branch June 7, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesper-friis @francescalb